[SOLR-16583] Rename CloudSolrClientBuilder in SolrTestCaseJ4 to RandomizingCloudSolrClientBuilder

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: main (10.0), 9.2
• Component/s: Integration Tests
• Assignee: Eric Pugh
• Reporter: Eric Pugh
• Created: 10/Dec/22 12:10
• Updated: 27/Mar/23 18:04
• Resolved: 27/Dec/22 17:09

Description

I've been chasing may way through the confusion of various Builders, and to my dismay discovered that we have in SolrTestCaseJ4 defined a builder that is designed to do some randomization!

public static class CloudSolrClientBuilder extends CloudLegacySolrClient.Builder

 

This gets super confusing cause there is a test called CloudSolrClientBuilderTest that makes me think it tests the above class, but it doesnt'.   in a previous commit we renamed a similar confusing pattern to

RandomizingCloudHttp2SolrClientBuilder

so this would be to clarify what this builder is.

  

Issue Links

• links to: GitHub Pull Request #1249