[SOLR-1648] Rename XMLWriter (and XMLResponseWriter) to SolrXmlResponseWriter

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.2, 1.3, 1.4
• Component/s: Response Writers

Environment

My local MacBook pro over the Christmas Break.

• Assignee: Unassigned
• Reporter: Chris A. Mattmann
• Created: 12/Dec/09 04:59
• Updated: 24/Oct/16 02:47
• Resolved: 24/Oct/16 02:47

Description

The current XMLWriter class is kind of a misnomer. It's not a generic XMLWriter by any means, and that's not its intention. Its intention is to write instances (as responses) of a particular XML schema that SOLR clients (written in Java, Python, pick-your-favorite-programming-language) that speak its XML protocol can understand. So, we should rename it to SolrXmlResponseWriter to indicate its unique XML speak.

Morever, as part of the next issue I'm going to report (refactoring all ResponseWriters to be a bit more friendly), we should probably do away with the current XmlResponseWriter (which simply delegates to XmlWriter – eeep) and just stick with SolrXmlResponseWriter. Patch forthcoming.

Issue Links

• is part of: SOLR-1646 Document the SOLR XML response schema in XMLSchema and DTD