I'm definitely not going to commit the same patch which is attached. I will ensure that all tests pass before this goes in.
I guess this is a communication error. I took
I plan to commit this shortly.
as "you are going to commit the current patch".
I guessed that you might do a few things before committing, but I have no way of knowing. When someone says that they plan to commit something shortly,
I take it to mean something along the lines of the patch posted. As you are missing two things that are pretty major pieces to this patch (the deprecation/non deprecation approach and a good workaround
for the tests), I voiced my opposition to the current approach shown. Its hard for me to guess what changes you will make to this patch before you commit soon - I have to assume when you say that you are committing shortly that perhaps you will address both things correctly and perhaps you won't - you could just commit the current patch, who knows - I can't really rely on you doing anything unless you post the patch first, but you mention nothing of another patch, just of committing. Thats why I brought up the issues that I did. I can see making some last minutes changes to a patch, but these two things are fairly important to this issue I feel, and not really last minute tweaks before a commit.
I'd like the opportunity to take a look at how you are going to address these two issues and (fwiw) possibly provide feedback.