[SOLR-16476] Remove commons-text dependency from solr-core

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: main (10.0), 9.2
• Component/s: Admin UI, Build
• Labels: newdev
• Assignee: Kevin Risden
• Reporter: David Smiley
• Created: 19/Oct/22 15:38
• Updated: 27/Mar/23 18:04
• Resolved: 25/Oct/22 17:21

Description

I don't think we really need commons-text in solr-core. I see it's for only one usage:
https://github.com/apache/solr/blob/c99af207c761ec34812ef1cc3054eb2804b7448b/solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java#L83

String[] search = new String[] {"${contextPath}", "${adminPath}", "${version}"};
        String[] replace =
            new String[] {
              StringEscapeUtils.escapeEcmaScript(request.getContextPath()),
              StringEscapeUtils.escapeEcmaScript(CommonParams.CORES_HANDLER_PATH),
              StringEscapeUtils.escapeEcmaScript(pack.getSpecificationVersion())
            };

But contextPath & adminPath are no longer in our admin pages. "version" is. Regardless, I don't see why we need to escape EcmaScript; these variables come from internal/validated sources that will not have user provided data that could hack the pages.

Issue Links

• is related to: SOLR-16464 Upgrade commons-text to 1.10.0
• relates to: SOLR-4311 Admin UI - Optimize Caching Behaviour
• relates to: SOLR-10042 Delete old deprecated Admin UI
• links to: GitHub Pull Request #1122