[SOLR-16363] DirectUpdateHandler2 should not throw UnknownFormatConversionException

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0, 8.11.2, 9.1
• Fix Version/s: main (10.0), 9.2
• Component/s: UpdateRequestProcessors
• Assignee: Kevin Risden
• Reporter: Aman Verma
• Created: 31/Aug/22 01:22
• Updated: 27/Mar/23 18:04
• Resolved: 26/Oct/22 02:43

Description

In certain situation, to handle IllegalArgumentException while adding doc to solr is linked below

https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.2/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java#L249

EDIT: Adding Code piece for current main branch: https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java#L314

 

This can be problematic if IllegalArgumentException (of the following format) is thrown during processing of docs (in my case it was via Filters to URL-Decode a string)

 

 java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - Error at index 0 in: "sy"

The iae.getMessage() in this case contains "%)" which conflicts with String.format which would further throw

java.util.UnknownFormatConversionException: Conversion = ')'
        at java.util.Formatter.checkText(Unknown Source) ~[?:?]
        at java.util.Formatter.parse(Unknown Source) ~[?:?]
        at java.util.Formatter.format(Unknown Source) ~[?:?]
        at java.util.Formatter.format(Unknown Source) ~[?:?]
        at java.lang.String.format(Unknown Source) ~[?:?]
        at org.apache.solr.update.DirectUpdateHandler2.addDoc(DirectUpdateHandler2.java:249)

This particular exception is not caught and as a result the BAD_REQUEST was never returned to the client along with failure point in the chain.

The ticket is a proposal to make this more robust i.e., in this particular situation either getMessage() could replaceAll "%" or perhaps another try?

 

 

Issue Links

• links to: GitHub Pull Request #1121
• links to: GitHub Pull Request #1124