[SOLR-16341] Error when upload configset with empty file entry

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 9.0, 8.11.2
• Component/s: configset-api
• Labels: newdev
• Assignee: Unassigned
• Reporter: Mike Drob
• Created: 17/Aug/22 21:41
• Updated: 27/Oct/22 17:34

Description

Confirmed with both 8.11 and 9.0

When uploading a configset that contains an empty file (likely this might be a synonyms or stop words or some other auxiliary file) our zip processing will throw an exception:

2022-08-17 21:36:07.618 ERROR (qtp1142347343-28) [] o.a.s.s.HttpSolrCall java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor => java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor
	at java.base/java.util.zip.ZipInputStream.readLOC(Unknown Source)
java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor
	at java.util.zip.ZipInputStream.readLOC(Unknown Source) ~[?:?]
	at java.util.zip.ZipInputStream.getNextEntry(Unknown Source) ~[?:?]
	at org.apache.solr.handler.admin.ConfigSetsHandler.handleConfigUploadRequest(ConfigSetsHandler.java:247) ~[?:?]
	at org.apache.solr.handler.admin.ConfigSetsHandler.handleRequestBody(ConfigSetsHandler.java:113) ~[?:?]
	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:207) ~[?:?]

I believe this issue is described at https://commons.apache.org/proper/commons-compress/zip.html, although the description is for apache commons, they claim ZipArchiveInputStream shares these limitations with java.util.zip.ZipInputStream

Steps to reproduce:

>stopwords.txt
zip -r - * | curl -X POST --header "Content-Type:application/octet-stream" --data-binary @- "http://localhost:8983/solr/admin/configs?action=UPLOAD&name=c1"