[SOLR-16191] Sanity-check assumptions about Linux `ps` command in `solr/bin/solr` script

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0, 8.11.2, main (10.0)
• Fix Version/s: 8.11.2, 9.1, main (10.0), 9.0.1
• Component/s: scripts and tools
• Assignee: Mike Drob
• Reporter: Michael Gibney
• Created: 10/May/22 15:12
• Updated: 22/Jun/22 17:34
• Resolved: 19/May/22 19:12

Description

SOLR-15558 made more apparent some assumptions/implicit dependencies on the Linux ps command in the solr/bin/solr script. The script already disables running in cygwin because of utility version incompatibility, but perhaps we could also/instead add "walks like a duck" sanity-check, e.g.:

if [ "$$" != "`ps -o pid='' $$`" ]; then
  exit 1
fi

The issue arose while running gradlew :solr:packaging:integrationTests for Alpine Linux with BusyBox ps installed, for which ps -o pid='' $WHATEVER dumps all running pids, regardless of the value of $WHATEVER. The behavior observed appeared mainly to affect solr stop, where the command watches for the PID to exit, but the pid is never detected as having exited. I'm not sure, it's possible that jstack/kill was being run against random PIDs!

Issue Links

• is related to: SOLR-15558 Solr stop doesn't handle zombie processes
• links to: GitHub Pull Request #867