[SOLR-16154] ZKEventListenerThread leaks from tests

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.1, main (10.0)
• Assignee: Mike Drob
• Reporter: Mike Drob
• Created: 13/Apr/22 18:51
• Updated: 10/Jan/23 20:45
• Resolved: 17/Oct/22 18:52

Description

Seen repeatedly on Jenkins.

com.carrotsearch.randomizedtesting.ThreadLeakError: 1 thread leaked from SUITE scope at org.apache.solr.handler.designer.TestSchemaDesignerSettingsDAO: 
   1) Thread[id=1089, name=ZKEventListenerThread, state=TIMED_WAITING, group=TGRP-TestSchemaDesignerSettingsDAO]
        at java.base@18/java.lang.Thread.sleep(Native Method)
        at app//org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:161)
        at app//org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:82)
        at app//org.apache.solr.common.cloud.SolrZkClient.getData(SolrZkClient.java:361)
        at app//org.apache.solr.cloud.ZkSolrResourceLoader.openResource(ZkSolrResourceLoader.java:75)
        at app//org.apache.lucene.analysis.AbstractAnalysisFactory.getLines(AbstractAnalysisFactory.java:302)
        at app//org.apache.lucene.analysis.AbstractAnalysisFactory.getWordSet(AbstractAnalysisFactory.java:293)
        at app//org.apache.lucene.analysis.en.AbstractWordsFileFilterFactory.inform(AbstractWordsFileFilterFactory.java:88)
        at app//org.apache.solr.core.SolrResourceLoader.informAware(SolrResourceLoader.java:762)
        at app//org.apache.solr.schema.ManagedIndexSchema.informResourceLoaderAwareObjectsInChain(ManagedIndexSchema.java:1470)
        at app//org.apache.solr.schema.ManagedIndexSchema.informResourceLoaderAwareObjectsForFieldType(ManagedIndexSchema.java:1319)
        at app//org.apache.solr.schema.ManagedIndexSchema.postReadInform(ManagedIndexSchema.java:1307)
        at app//org.apache.solr.schema.IndexSchema.readSchema(IndexSchema.java:654)
        at app//org.apache.solr.schema.IndexSchema.<init>(IndexSchema.java:188)
        at app//org.apache.solr.schema.ManagedIndexSchema.<init>(ManagedIndexSchema.java:119)
        at app//org.apache.solr.schema.ManagedIndexSchemaFactory.create(ManagedIndexSchemaFactory.java:279)
        at app//org.apache.solr.schema.ManagedIndexSchemaFactory.create(ManagedIndexSchemaFactory.java:51)
        at app//org.apache.solr.core.ConfigSetService.createIndexSchema(ConfigSetService.java:342)
        at app//org.apache.solr.core.ConfigSetService.lambda$loadConfigSet$0(ConfigSetService.java:253)
        at app//org.apache.solr.core.ConfigSetService$$Lambda$632/0x0000000801137758.get(Unknown Source)
        at app//org.apache.solr.core.ConfigSet.<init>(ConfigSet.java:49)
        at app//org.apache.solr.core.ConfigSetService.loadConfigSet(ConfigSetService.java:249)
        at app//org.apache.solr.core.CoreContainer.reload(CoreContainer.java:1850)
        at app//org.apache.solr.core.SolrCore.lambda$getConfListener$21(SolrCore.java:3394)
        at app//org.apache.solr.core.SolrCore$$Lambda$742/0x00000008011f2560.run(Unknown Source)
        at app//org.apache.solr.cloud.ZkController.lambda$fireEventListeners$18(ZkController.java:2761)
        at app//org.apache.solr.cloud.ZkController$$Lambda$1153/0x00000008014e8938.run(Unknown Source)
        at java.base@18/java.lang.Thread.run(Thread.java:833)
	at __randomizedtesting.SeedInfo.seed([DE9B93CA6D75B373]:0)

Issue Links

• is duplicated by: SOLR-16066 Fix unmanaged Thread in ZkController
• is related to: SOLR-16187 ExecutorUtil#awaitTermination shouldn't wait forever
• relates to: SOLR-16178 ZkController#fireEventListeners thread should be shutdown on close
• links to: GitHub Pull Request #805
• links to: GitHub Pull Request #834