[SOLR-16120] optimise glob-free hl.fl expansion

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.1, main (10.0)
• Component/s: highlighter
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 28/Mar/22 10:26
• Updated: 10/Jan/23 20:45
• Resolved: 30/Mar/22 12:32

Description

Currently SolrDocumentFetcher.getStoredHighlightFieldNames() is always called but the result is actually only used if there's a * present e.g. hl.fl=fieldA,fieldB* would use it but hl.fl=fieldA,fieldB or hl.fl=fieldA would not use it.

If a field names supplier is used instead of the field names themselves the call can be deferred until needed and thus avoided if not needed.

Issue Links

• is related to: SOLR-16111 hl.queryFieldPattern support (advanced alternative to hl.requireFieldMatch)
• links to: GitHub Pull Request #767