Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-16120

optimise glob-free hl.fl expansion

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 9.1, main (10.0)
    • highlighter
    • None

    Description

      Currently SolrDocumentFetcher.getStoredHighlightFieldNames() is always called but the result is actually only used if there's a * present e.g. hl.fl=fieldA,fieldB* would use it but hl.fl=fieldA,fieldB or hl.fl=fieldA would not use it.

      If a field names supplier is used instead of the field names themselves the call can be deferred until needed and thus avoided if not needed.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cpoerschke Christine Poerschke
            cpoerschke Christine Poerschke
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 50m
                1h 50m

                Slack

                  Issue deployment