Solr
  1. Solr
  2. SOLR-1595

StreamingUpdateSolrServer doesn't specifying UTF-8 when creating OutputStreamWriter

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3, 1.4
    • Fix Version/s: 1.4.1, 1.5, 3.1, 4.0-ALPHA
    • Component/s: clients - java
    • Labels:
      None

      Description

      StreamingUpdateSolrServer constructs an OutputStreamWriter w/o specifying that it should use UTF-8 ... as a result the JVMs default encoding is used even though the request includes a Content-Type header of "text/xml; charset=utf-8" via CLientUtisl.TEXT_XML.

      1. SOLR-1595.patch
        2 kB
        Yonik Seeley

        Activity

        Show
        Hoss Man added a comment - first noted here... http://old.nabble.com/UTF-8-Character-Set-not-specifed-on-OutputStreamWriter-in-StreamingUpdateSolrServer-td26400932.html#a26400932
        Hide
        Yonik Seeley added a comment -

        Here's the patch.

        Show
        Yonik Seeley added a comment - Here's the patch.
        Hide
        Yonik Seeley added a comment -

        The included test fails (w/o the rest of the patch) with the following command line:

        ant test -Dargs="-Dfile.encoding=ISO8859_1" -Dtestcase=SolrExampleStreamingTest
        
        Show
        Yonik Seeley added a comment - The included test fails (w/o the rest of the patch) with the following command line: ant test -Dargs= "-Dfile.encoding=ISO8859_1" -Dtestcase=SolrExampleStreamingTest
        Hide
        Yonik Seeley added a comment -

        committed.

        Show
        Yonik Seeley added a comment - committed.
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Hoss Man added a comment -

        Committed revision 949470.

        merged to branch-1.4 for 1.4.1

        Show
        Hoss Man added a comment - Committed revision 949470. merged to branch-1.4 for 1.4.1

          People

          • Assignee:
            Unassigned
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development