Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.4.1, 1.5, 3.1, 4.0-ALPHA
    • Component/s: web gui
    • Labels:
      None

      Description

      The fix to SOLR-1008 was wrong. It used chardata escaping for a value that is an attribute value.

      I.e. instead of XML.escapeCharData it should call XML.escapeAttributeValue.

      Otherwise, any query used as a key in the filter cache whose printed representation contains a double-quote character causes invalid XML to be generated.

      1. SOLR-1579.patch
        0.5 kB
        David Bowen

        Issue Links

          Activity

          Hide
          David Bowen added a comment -

          This is a trivial fix, but I'm supplying a patch in the hope of raising the priority.

          Show
          David Bowen added a comment - This is a trivial fix, but I'm supplying a patch in the hope of raising the priority.
          Hide
          Hoss Man added a comment -

          I fully expect stats.jsp will be deprecated in the next release of Solr in favor of the handler in SOLR-1750 – BUT – I still can't beleive such an anoying and yet trivial to fix bug was arround for so long ... especially since the incorrect fix for the XML attribute escaping is only half the problem: escapeCharData as still needed for the XML ELement content escaping.

          David: thanks for your prodding on this ... i committed your patch plus some additional fixes (r909705)

          Show
          Hoss Man added a comment - I fully expect stats.jsp will be deprecated in the next release of Solr in favor of the handler in SOLR-1750 – BUT – I still can't beleive such an anoying and yet trivial to fix bug was arround for so long ... especially since the incorrect fix for the XML attribute escaping is only half the problem: escapeCharData as still needed for the XML ELement content escaping. David: thanks for your prodding on this ... i committed your patch plus some additional fixes (r909705)
          Hide
          Hoss Man added a comment -

          Correcting Fix Version based on CHANGES.txt, see this thread for more details...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Show
          Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
          Hide
          Hoss Man added a comment -

          Committed revision 949890.

          merged to branch-1.4. for 1.4.1

          Show
          Hoss Man added a comment - Committed revision 949890. merged to branch-1.4. for 1.4.1

            People

            • Assignee:
              Hoss Man
              Reporter:
              David Bowen
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development