Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5, 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      Make it easier and less error prone to add simple functions.

      1. SOLR-1574.patch
        11 kB
        Yonik Seeley
      2. SOLR-1574.patch
        3 kB
        Yonik Seeley

        Activity

        Hide
        Yonik Seeley added a comment -

        Related to SOLR-1302, which added new full classes for things that essentially boil down to a single call to a Math.* method.
        There was a lot of boilerplate code copied, and also some bugs (like not delegating createWeight to their sources).

        Show
        Yonik Seeley added a comment - Related to SOLR-1302 , which added new full classes for things that essentially boil down to a single call to a Math.* method. There was a lot of boilerplate code copied, and also some bugs (like not delegating createWeight to their sources).
        Hide
        Yonik Seeley added a comment -

        Prototype (representative) patch attached.
        We should probably convert some other functions like sqrt, since there is no Math.sqrt(float) hence is must convert anyway. Making it ask for a double and expose a double will be back compatible and simply shift where the conversion to a float takes place.

        Show
        Yonik Seeley added a comment - Prototype (representative) patch attached. We should probably convert some other functions like sqrt, since there is no Math.sqrt(float) hence is must convert anyway. Making it ask for a double and expose a double will be back compatible and simply shift where the conversion to a float takes place.
        Hide
        Yonik Seeley added a comment -

        The other purpose is to move and share standard parsing code since many functions really just want to specify the function.

        Show
        Yonik Seeley added a comment - The other purpose is to move and share standard parsing code since many functions really just want to specify the function.
        Hide
        Grant Ingersoll added a comment -

        +1. This was my first time writing functions. Overall, pretty easy to do, but in some cases I felt I was copying a lot of code, with the primary difference being the number of DocValues I needed to pass through. Not quite sure how to handle that in a more general way.

        Show
        Grant Ingersoll added a comment - +1. This was my first time writing functions. Overall, pretty easy to do, but in some cases I felt I was copying a lot of code, with the primary difference being the number of DocValues I needed to pass through. Not quite sure how to handle that in a more general way.
        Hide
        Yonik Seeley added a comment -

        Update adding a bunch of other functions from Math (sin,cos, etc) now that it's easier / smaller to do so.

        Show
        Yonik Seeley added a comment - Update adding a bunch of other functions from Math (sin,cos, etc) now that it's easier / smaller to do so.
        Hide
        Yonik Seeley added a comment -

        committed.

        Show
        Yonik Seeley added a comment - committed.
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development