[SOLR-15700] Fix include path consistency in bin/solr shell wrapper

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.10
• Fix Version/s: 9.0
• Component/s: scripts and tools
• Labels: easyfix patch pull-request-available

Environment

CentOS 7, Solr 8.10.1
–
openjdk version "11.0.12" 2021-07-20 LTS
OpenJDK Runtime Environment 18.9 (build 11.0.12+7-LTS)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.12+7-LTS, mixed mode, sharing
–
GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu)
Copyright (C) 2011 Free Software Foundation, Inc.

• Assignee: Eric Pugh
• Reporter: Trevor Turner
• Created: 19/Oct/21 01:47
• Updated: 12/May/22 00:26
• Resolved: 19/Nov/21 20:09

Description

The shell script bin/solr states the paths it will search for solr.in.sh in a comment near the top of the script, however, not all of these paths are consistent with the logic that actually searches for the file.

Since one can either edit the script in their own packaging/deployment or simply use the SOLR_INCLUDE env variable, this doesn't pose much of a problem, but is a minor annoyance if configuring a package based on this comment.

I've created and attached a patch that includes all paths consistently in both places.

Issue Links

• links to: GitHub Pull Request #358