[SOLR-15628] SolrException.log doesn't pass Throwable to Logger correctly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0, 8.11
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 13/Sep/21 18:45
• Updated: 17/Nov/21 14:22
• Resolved: 14/Sep/21 17:47

Description

Having recently started using JSON based logging, I noticed that in many code paths situations where an error involving a "Throwable" are logged isn't happening correctly (This is also noticeable using the default solr log4j2.xml configuration - but only subtly)

The problem is that SolrException.log(...) has some very old (pre Solr 1.0, certainly pre SLF4j/Log4j) and hackish logic/code in it to support SolrException.ignorePatterns (which was designed for tests that wanted "quieter" output when they were intentionally triggering error situations. This logic "stringifies" the entire Throwable (including stack trace) to test against any ignorePatterns that exist (even if there are no ignore patterns) before handing the resulting string off to the loggger.error(...) call – as a log message string - w/o the normal "structure" context of the original Throwable instance.

This causes the full exception stack trace to come through as the log "message" – even in log appenders that have been configured to only log partial stack trace details, or log them in special fields (ie: JSON Logging)

Issue Links

• is related to: SOLR-15697 replace SolrException.ignorePatterns with something that doesn't depend on SolrException.log()
• relates to: SOLR-15629 Improve the way we "expect" ERROR messages in tests