Solr
  1. Solr
  2. SOLR-1558

QueryElevationComponent should fail to init if uniqueKey field isn't string

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3, 1.4
    • Fix Version/s: 1.4.1, 1.5, 3.1, 4.0-ALPHA
    • Component/s: search
    • Labels:
      None

      Description

      QueryElevationComponent fails in confusing ways if you use it on a schema where the uniqueKey fieldtype is not a StrField. This is easy to assert at init, so we should do that.

        Issue Links

          Activity

          Hoss Man created issue -
          Hoss Man made changes -
          Field Original Value New Value
          Link This issue relates to SOLR-1520 [ SOLR-1520 ]
          Hide
          Hoss Man added a comment -

          SOLR-1520 request that we make QEC work with any uniqueKey type, so it is related – but that goal is likely harder to achieve then a simple/helpful error message on startup so i'm tracking them as separate issues.

          Show
          Hoss Man added a comment - SOLR-1520 request that we make QEC work with any uniqueKey type, so it is related – but that goal is likely harder to achieve then a simple/helpful error message on startup so i'm tracking them as separate issues.
          Hide
          Hoss Man added a comment -

          Committed revision 884393.

          Note that the code change only required modifying two lines, but this fix exposed 7 test config files that had cut/paste declaations of the elevation component that weren't used, and never would have worked because of the schema used in the tests.

          Show
          Hoss Man added a comment - Committed revision 884393. Note that the code change only required modifying two lines, but this fix exposed 7 test config files that had cut/paste declaations of the elevation component that weren't used, and never would have worked because of the schema used in the tests.
          Hoss Man made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Hoss Man [ hossman ]
          Resolution Fixed [ 1 ]
          Hide
          Hoss Man added a comment -

          Correcting Fix Version based on CHANGES.txt, see this thread for more details...

          http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

          Show
          Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
          Hoss Man made changes -
          Fix Version/s 3.1 [ 12314371 ]
          Fix Version/s 4.0 [ 12314992 ]
          Hide
          Hoss Man added a comment -

          Committed revision 949888.

          merged to branch-1.4 for 1.4.1

          Show
          Hoss Man added a comment - Committed revision 949888. merged to branch-1.4 for 1.4.1
          Hoss Man made changes -
          Fix Version/s 1.4.1 [ 12315096 ]
          Mark Miller made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          13d 7h 21m 1 Hoss Man 26/Nov/09 03:23
          Resolved Resolved Closed Closed
          224d 16h 32m 1 Mark Miller 08/Jul/10 20:55

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development