Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-15486

consider SolrCoreState.inflightUpdatesCounter logic in ZK-unware Solr

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • main (9.0), 8.10
    • None
    • None

    Description

      SOLR-14942 added the inflightUpdatesCounter logic to reduce leader election time on node shutdown.

      From my understanding of the code so far:

      • Since the earlier triggering of an election is specific to ZK-aware Solr then one could say that ContentStreamHandlerBase.handleRequestBody doing inflight update registers and deregisters is unnecessary.
      • Alternatively if waiting for inflight updates to complete (at that point in the shutdown sequence) is generally beneficial then one could say that the pauseUpdatesAndAwaitInflightRequests logic should be added for the ZK-unware code path in CoreContainer.shutdown also.

      Illustrative draft pull request with both options: https://github.com/apache/solr/pull/180

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            cpoerschke Christine Poerschke
            cpoerschke Christine Poerschke
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 40m
                40m

                Issue deployment