[SOLR-15486] consider SolrCoreState.inflightUpdatesCounter logic in ZK-unware Solr

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0, 8.10
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 17/Jun/21 16:20
• Updated: 28/Sep/21 20:22
• Resolved: 03/Aug/21 17:59

Description

SOLR-14942 added the inflightUpdatesCounter logic to reduce leader election time on node shutdown.

From my understanding of the code so far:

• Since the earlier triggering of an election is specific to ZK-aware Solr then one could say that ContentStreamHandlerBase.handleRequestBody doing inflight update registers and deregisters is unnecessary.

• Alternatively if waiting for inflight updates to complete (at that point in the shutdown sequence) is generally beneficial then one could say that the pauseUpdatesAndAwaitInflightRequests logic should be added for the ZK-unware code path in CoreContainer.shutdown also.

Illustrative draft pull request with both options: https://github.com/apache/solr/pull/180

Issue Links

• is related to: SOLR-14942 Reduce leader election time on node shutdown
• links to: GitHub Pull Request #180