[SOLR-15438] Refactor: Simplify SolrDispatchFilter close/destroy

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 26/May/21 18:35
• Updated: 26/Feb/24 00:00

Description

SolrDispatchFilter's close process is more convoluted than it needs to be. There is conditionality via a boolean closeOnDestory that JettySolrRunner uses, yet it seems it doesn't really need this logic. JSR could instead call Jetty FilterHolder stop() method which tracks lifecycle to know if it hasn't been called, and it can skip needless null checks. Also SDF's reference to CoreContainer needn't be null'ed out, which makes some logic simpler above that needn't guard against null. The HttpClient needn't be null'ed either. We don't need a reference to SolrMetricManager; it can be gotten from CoreContainer easily.

Issue Links

• is related to: SOLR-12896 Introduce more checks for shutdown and closed to improve clean close and shutdown.
• is related to: SOLR-10615 latch SolrDispatchFilter.doFilter() on init() completion
• links to: GitHub Pull Request #155