Solr
  1. Solr
  2. SOLR-1532

allow StreamingUpdateSolrServer to use a provided HttpClient

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5, 3.1, 4.0-ALPHA
    • Component/s: clients - java
    • Labels:
      None

      Description

      As of r830319 StreamingUpdateSolrServer does not allow calling code to provide an HttpClient, and this implies client code cannot reuse an existing connection manager, the patch adds a new constructor and refactors the old one to use this.

      1. SOLR-1532.patch
        2 kB
        gabriele renzi
      2. SOLR-1532.patch
        2 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        gabriele renzi added a comment -

        the patch implements the change, adds a few lines of documentation but does not introduce new tests as they would be pointless. Existing tests still pass.

        Show
        gabriele renzi added a comment - the patch implements the change, adds a few lines of documentation but does not introduce new tests as they would be pointless. Existing tests still pass.
        Hide
        Shalin Shekhar Mangar added a comment -

        Synced to trunk. I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Synced to trunk. I'll commit this shortly.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 890769.

        Thanks Gabriele!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 890769. Thanks Gabriele!
        Hide
        gabriele renzi added a comment -

        thanks toy you, I was starting to lose hope

        Show
        gabriele renzi added a comment - thanks toy you, I was starting to lose hope
        Hide
        Hoss Man added a comment -

        Correcting Fix Version based on CHANGES.txt, see this thread for more details...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Show
        Hoss Man added a comment - Correcting Fix Version based on CHANGES.txt, see this thread for more details... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1.0 release

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1.0 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            gabriele renzi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development