Simple patch that will avoid the NullPointerException, but doesn't fix the issue.

I'm not at a machine where i can try to reproduce this, but i want to try and understand the severity ... looking at LogUPdateProcessorFactory via viewvc, I believe what this bug is reporting is that if a single request includes more then 8 (maxNumToLog) deleteByQuery directives, w/o including any deleteById directives, then the logger will generate an NPE. (regardless of how many docs were deleted)

Which means something like this would probably be a way to recreate it in the example...

java -Ddata=args -jar post.jar "<delete><query>X</query><query>X</query>
           <query>X</query><query>X</query><query>X</query><query>X</query>
           <query>X</query><query>X</query><query>X</query></delete>"

... and adding a single <id> entry (even if bogus, or possibly blank) would work arround the problem....

java -Ddata=args -jar post.jar "<delete><query>X</query><query>X</query>
             <query>X</query><query>X</query><query>X</query><query>X</query>
             <query>X</query><query>X</query><query>X</query><id /></delete>"

java -Ddata=args -jar post.jar "<delete><query>X</query><query>X</query>
             <query>X</query><query>X</query><query>X</query><query>X</query>
             <query>X</query><query>X</query><query>X</query><id>NOT_A_REAL_ID</id></delete>"

...is that all correct?

Questions should influence whether we consider this a show stopper for 1.4...

• Does the update succeed in spite of the NPE, or does the entire update fail?
• Is this bug new in 1.4, or will it also occur in 1.3 (skimming viewvc for the 1.3 tag it looks like this bug has been around for a while)

Does the update succeed in spite of the NPE, or does the entire update fail?

The deletes should still succeed - the logger chains before it does stuff.

Is this bug new in 1.4, or will it also occur in 1.3 (skimming viewvc for the 1.3 tag it looks like this bug has been around for a while)

It does indeed look like it's been around since the beginning (7/07)

In case it wasn't clear - I don't consider this a 1.4 showstopper.

Just to clarify from our point of view:

What our client using the Solr web application see when it processes a request (... containing more than 8 *byQuery and no *byId) is an exception (we cant differentiate between types of errors, we simply get an exception and have to rollback). It might for example look like the following sample code:

PSEUDO-CODE

try {
  while (hasMoreDeletesToProcessFromOurApplication) {
    if (requestBatchMaxSizeReached) {
      break;
    }

    request.deleteByQuery(...)
  }

  request.process(solrServer)
  solServer.commit()
} catch (Exception e) {
  // SolrServerException or IOException

  solrServer.rollback();
  throw e;
}

Thanks, I just committed your patch (though I had to apply it by hand).

Bulk close for Solr 1.4