Solr
  1. Solr
  2. SOLR-1510

EmbeddedSolrServer should support multiple cores

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      currently , EmbeddedSolrServer can be started only with single core. This restriction should be removed

        Activity

        Hide
        Ryan McKinley added a comment -

        we went back and forth on this one for a while. Originally solrj knew how to handle different cores.

        What is the advantage of a single EmbeddedSolrServer talking to multiple cores vs an EmbeddedSolrServer for each core? (perhaps in a Map<String,EmbeddedSolrServer>)

        IIRC, adding cores to the SolrServer API gets complicated with the HTTP version – but I don't remember exactly why.

        Show
        Ryan McKinley added a comment - we went back and forth on this one for a while. Originally solrj knew how to handle different cores. What is the advantage of a single EmbeddedSolrServer talking to multiple cores vs an EmbeddedSolrServer for each core? (perhaps in a Map<String,EmbeddedSolrServer>) IIRC, adding cores to the SolrServer API gets complicated with the HTTP version – but I don't remember exactly why.
        Hide
        Yonik Seeley added a comment -

        If you keep a client per core, it's all nice and transparent - a core could be moved to another server and only that client needs to be changed.

        Show
        Yonik Seeley added a comment - If you keep a client per core, it's all nice and transparent - a core could be moved to another server and only that client needs to be changed.
        Hide
        Noble Paul added a comment -

        What is the advantage of a single EmbeddedSolrServer talking to multiple cores vs an EmbeddedSolrServer for each core

        By doing that the user may not be able to take advantage of the functionalities provided by CoreContainer (CoreAdmin commands). There is no reason why an EmbeddedSolrServer should not be able to use those features. We can always add a 'core' parameter to the commands and it should work fine. Yes, adding a core parameter is inconsistent with the standard http mode but it is definitely better than not having the feature at all

        Show
        Noble Paul added a comment - What is the advantage of a single EmbeddedSolrServer talking to multiple cores vs an EmbeddedSolrServer for each core By doing that the user may not be able to take advantage of the functionalities provided by CoreContainer (CoreAdmin commands). There is no reason why an EmbeddedSolrServer should not be able to use those features. We can always add a 'core' parameter to the commands and it should work fine. Yes, adding a core parameter is inconsistent with the standard http mode but it is definitely better than not having the feature at all
        Hide
        Lance Norskog added a comment -

        What about having "solr://" and "solr://core" URI formats? This would correspond to an embedded server.

        There could be one master SolrJ connection factory that takes the "solr://" or "http://....." URIs.

        Show
        Lance Norskog added a comment - What about having "solr://" and "solr://core" URI formats? This would correspond to an embedded server. There could be one master SolrJ connection factory that takes the "solr://" or "http://....." URIs.
        Hide
        Noble Paul added a comment -

        What about having "solr://" and "solr://core" URI formats? This would correspond to an embedded server.

        I don't know if we support solr:// urls. The fact that somebody is using EmbeddedSolrServer means he is using it as an API. The url is no more important

        Show
        Noble Paul added a comment - What about having "solr://" and "solr://core" URI formats? This would correspond to an embedded server. I don't know if we support solr:// urls. The fact that somebody is using EmbeddedSolrServer means he is using it as an API. The url is no more important
        Hide
        Hoss Man added a comment -

        Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email...

        http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E

        Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed.

        A unique token for finding these 240 issues in the future: hossversioncleanup20100527

        Show
        Hoss Man added a comment - Bulk updating 240 Solr issues to set the Fix Version to "next" per the process outlined in this email... http://mail-archives.apache.org/mod_mbox/lucene-dev/201005.mbox/%3Calpine.DEB.1.10.1005251052040.24672@radix.cryptio.net%3E Selection criteria was "Unresolved" with a Fix Version of 1.5, 1.6, 3.1, or 4.0. email notifications were suppressed. A unique token for finding these 240 issues in the future: hossversioncleanup20100527
        Hide
        Robert Muir added a comment -

        Bulk move 3.2 -> 3.3

        Show
        Robert Muir added a comment - Bulk move 3.2 -> 3.3
        Hide
        Robert Muir added a comment -

        3.4 -> 3.5

        Show
        Robert Muir added a comment - 3.4 -> 3.5
        Hide
        Hoss Man added a comment -

        bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment

        Show
        Hoss Man added a comment - bulk fixing the version info for 4.0-ALPHA and 4.0 all affected issues have "hoss20120711-bulk-40-change" in comment
        Hide
        Robert Muir added a comment -

        rmuir20120906-bulk-40-change

        Show
        Robert Muir added a comment - rmuir20120906-bulk-40-change
        Hide
        Hoss Man added a comment -

        There is no indication that anyone is actively working on this issue, so removing 4.0 from the fixVersion.

        Show
        Hoss Man added a comment - There is no indication that anyone is actively working on this issue, so removing 4.0 from the fixVersion.

          People

          • Assignee:
            Noble Paul
            Reporter:
            Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development