[SOLR-15001] Docker: require init_var_solr.sh; don't init in Dockerfile

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: Docker
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 15/Nov/20 18:06
• Updated: 12/May/22 00:27
• Resolved: 27/Nov/20 20:00

Description

I propose removing initialization of /var/solr from the Dockerfile, thus leaving only init_var_solr to do this. The fact that it's in two places means that the image has two solr.xml, two zoo.cfg, two log4j2.xml. This initialization itself must be maintained twice. That leads to confusion (it did with my colleagues and I) about which copy is going to be used. Imagine you are basing your company Solr Dockerfile on top of this one (i.e. official is the FROM) and need to do modifications. Do you modify /opt/solr/server/solr/solr.xml? Surprise surprise, sometimes it is copied to /var/solr/data/ by the init_var_solr script but sometimes it isn't because the Dockerfile here will do it, thus ignoring the customizations made to solr.xml in the next image layer.

After making this change, our wonderful tests exposed that solr-demo wasn't invoking init_var_solr.

THIS ISSUE IS COPIED FROM https://github.com/docker-solr/docker-solr/pull/354

Issue Links

• links to: GitHub Pull Request #2083