Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14914

Add option to disable metrics collection

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 8.7
    • metrics
    • None

    Description

      Some users have expressed concerns about the overhead of metrics collection, and consequently the need to have an option to turn off the metrics collection altogether.

      Metrics instrumentation in Solr cannot be itself easily removed or bypassed - in order to provide fine-grained metrics many code paths had to be changed and they now expect the metrics to be present (non-null). However, we can use the mechanism of MetricSupplier to provide singleton no-op implementations of all metrics, which would reduce the CPU overhead to basically the cost of an empty method call, and the memory overhead to a HashMap entry in a MetricRegistry (metric names still need to be tracked).

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ab Andrzej Bialecki
            ab Andrzej Bialecki
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m

                Slack

                  Issue deployment