Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1474

DataImportHandler tests leave dataimport.properties after finish

        Details

        • Type: Test
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.3
        • Fix Version/s: 1.4
        • Component/s: contrib - DataImportHandler
        • Labels:
          None

          Description

          DataImportHandler tests leave dataimport.properties after finish. A lot of tests which use last_index_time fail if dataimport.properties is removed in tearDown. Either the tests are wrong or there is a bug lurking somewhere. This needs to be fixed before 1.4 release.

          1. Text File
            SOLR-1474.patch
            7 kB
            Shalin Shekhar Mangar
          2. Text File
            SOLR-1474.patch
            2 kB
            Shalin Shekhar Mangar

            Issue Links

            blocks

            Bug - A problem which impairs or prevents the functions of the product. SOLR-1473 Unable to use last_index_time in FileListEntityProcessor newerThan/olderThan attributes

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              shalinmangar Shalin Shekhar Mangar added a comment -

              Changes to AbstractDataImportHandlerTest to delete dataimport.properties in tearDown method.

              TestSqlEntityProcessor2, TestSqlEntityProcessorDelta and TestSqlEntityProcessorDelta2 fail with this change.

              Show
              shalinmangar Shalin Shekhar Mangar added a comment - Changes to AbstractDataImportHandlerTest to delete dataimport.properties in tearDown method. TestSqlEntityProcessor2, TestSqlEntityProcessorDelta and TestSqlEntityProcessorDelta2 fail with this change.
              Hide
              Permalink
              shalinmangar Shalin Shekhar Mangar added a comment -

              There was a shortcut in DIH to do a full-import if last_index_time is not available even if a delta-import is requested. I believe we added that so that empty last_index_time doesn't give errors

              1. Removed last_index_time from DataImporter since DocBuilder reads it anyway
              2. If last_index_time is not present, use epoch

              All tests pass. I'll commit this shortly.

              Show
              shalinmangar Shalin Shekhar Mangar added a comment - There was a shortcut in DIH to do a full-import if last_index_time is not available even if a delta-import is requested. I believe we added that so that empty last_index_time doesn't give errors Removed last_index_time from DataImporter since DocBuilder reads it anyway If last_index_time is not present, use epoch All tests pass. I'll commit this shortly.
              Hide
              Permalink
              shalinmangar Shalin Shekhar Mangar added a comment -

              Committed revision 820235.

              Show
              shalinmangar Shalin Shekhar Mangar added a comment - Committed revision 820235.
              Hide
              Permalink
              gsingers Grant Ingersoll added a comment -

              Bulk close for Solr 1.4

              Show
              gsingers Grant Ingersoll added a comment - Bulk close for Solr 1.4

                People

                • Assignee:
                  shalinmangar Shalin Shekhar Mangar
                  Reporter:
                  shalinmangar Shalin Shekhar Mangar
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development