Details
-
Type:
Test
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.3
-
Fix Version/s: 1.4
-
Component/s: contrib - DataImportHandler
-
Labels:None
Description
DataImportHandler tests leave dataimport.properties after finish. A lot of tests which use last_index_time fail if dataimport.properties is removed in tearDown. Either the tests are wrong or there is a bug lurking somewhere. This needs to be fixed before 1.4 release.
Issue Links
- blocks
-
SOLR-1473
Unable to use last_index_time in FileListEntityProcessor newerThan/olderThan attributes
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
There was a shortcut in DIH to do a full-import if last_index_time is not available even if a delta-import is requested. I believe we added that so that empty last_index_time doesn't give errors
- Removed last_index_time from DataImporter since DocBuilder reads it anyway
- If last_index_time is not present, use epoch
All tests pass. I'll commit this shortly.
Show
Shalin Shekhar Mangar
added a comment - There was a shortcut in DIH to do a full-import if last_index_time is not available even if a delta-import is requested. I believe we added that so that empty last_index_time doesn't give errors
Removed last_index_time from DataImporter since DocBuilder reads it anyway
If last_index_time is not present, use epoch
All tests pass. I'll commit this shortly.
Committed revision 820235.
Show
Shalin Shekhar Mangar
added a comment - Committed revision 820235.
Bulk close for Solr 1.4
Show
Grant Ingersoll
added a comment - Bulk close for Solr 1.4
Changes to AbstractDataImportHandlerTest to delete dataimport.properties in tearDown method.
TestSqlEntityProcessor2, TestSqlEntityProcessorDelta and TestSqlEntityProcessorDelta2 fail with this change.