Solr
  1. Solr
  2. SOLR-1471

StatsComponent does not calculate number missing for facets

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      The StatsComponent always returns a missing value of 0 for stats.facet. The number of missing is calculated for the overall field statistics, but not for the facets.

      1. SOLR-1471.patch
        6 kB
        Grant Ingersoll
      2. SOLR-1471.patch
        3 kB
        James Miller

        Issue Links

          Activity

          Hide
          James Miller added a comment -

          Here is a patch and unit test for single value field that counts missing for facets.

          I'm not sure about multivalue fields, but I could try if someone points me in the right direction.

          Show
          James Miller added a comment - Here is a patch and unit test for single value field that counts missing for facets. I'm not sure about multivalue fields, but I could try if someone points me in the right direction.
          Hide
          Grant Ingersoll added a comment -

          Multivalued stuff is implemented in UninvertedField.java

          Show
          Grant Ingersoll added a comment - Multivalued stuff is implemented in UninvertedField.java
          Hide
          Grant Ingersoll added a comment -

          Here's a patch that tests for missing in multivalued, and thus fails. Fix still needs to be implemented.

          Show
          Grant Ingersoll added a comment - Here's a patch that tests for missing in multivalued, and thus fails. Fix still needs to be implemented.
          Hide
          Grant Ingersoll added a comment -

          I committed the fix for the single value case. Committed revision 821014.

          I don't have good bearings yet on fixing the multivalued case. I am going to open up a new issue and move that to 1.5, unless someone wants to take it up.

          Show
          Grant Ingersoll added a comment - I committed the fix for the single value case. Committed revision 821014. I don't have good bearings yet on fixing the multivalued case. I am going to open up a new issue and move that to 1.5, unless someone wants to take it up.
          Hide
          Yonik Seeley added a comment -

          Found it... in UnInvertedField.getStats(), the FieldType was being overwritten by the type of the facet fields.

          Show
          Yonik Seeley added a comment - Found it... in UnInvertedField.getStats(), the FieldType was being overwritten by the type of the facet fields.
          Hide
          Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          Grant Ingersoll added a comment - Bulk close for Solr 1.4

            People

            • Assignee:
              Grant Ingersoll
              Reporter:
              James Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development