[SOLR-14699] Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

• Type: Improvement
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Component/s: logging
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 31/Jul/20 15:55
• Updated: 20/Feb/24 00:00

Description

SolrQueryResponse.getToLogAsString encodes the NamedList into a String with simple space-separated pairs with name=value. However, it does no escaping/encoding, and as-such a value might itself contain spaces and equals. This is a problem if these logs are being parsed, and we'd like to ensure we do so correctly. Note that SolrLogPostTool (aka "postlogs") parses these logs.

Issue Links

• relates to: SOLR-15610 Support json formatted logging via conf: add log4j-layout-template-json to 'server'
• links to: GitHub Pull Request #882