[SOLR-14691] Metrics reporting should avoid creating objects

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 8.7
• Component/s: metrics
• Assignee: Andrzej Bialecki
• Reporter: Andrzej Bialecki
• Created: 29/Jul/20 13:54
• Updated: 04/Nov/20 15:22
• Resolved: 08/Oct/20 08:32

Description

MetricUtils unnecessarily creates a lot of short-lived objects (maps and lists). This affects GC, especially since metrics are frequently polled by clients. We should refactor it to use MapWriter as much as possible.

Alternatively we could provide our wrappers or subclasses of Codahale metrics that implement MapWriter, then a lot of complexity in MetricUtils wouldn't be needed at all.

Issue Links

• links to: GitHub Pull Request #1951