Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14691

Metrics reporting should avoid creating objects

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.7
    • Component/s: metrics
    • Labels:
      None

      Description

      MetricUtils unnecessarily creates a lot of short-lived objects (maps and lists). This affects GC, especially since metrics are frequently polled by clients. We should refactor it to use MapWriter as much as possible.

      Alternatively we could provide our wrappers or subclasses of Codahale metrics that implement MapWriter, then a lot of complexity in MetricUtils wouldn't be needed at all.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ab Andrzej Bialecki
                Reporter:
                ab Andrzej Bialecki
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h 40m
                  2h 40m