Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14651

Metrics history could disable itself better

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.7
    • Component/s: metrics
    • Labels:
      None

      Description

      The MetricsHistoryHandler should disable itself better than it does.  It will create a SolrRrdBackendFactory (which has an ExecutorService / thread pool) when it should not when the plugin is disabled.  Furthermore, I think this should be disabled by default in tests, as it's excessive machinery that don't matter to 99.9% of tests.  This will help our tests run more efficiently.

      While working on other issues, I also occasionally saw a thread leak failure with the RRD being the leaked threads.  I see that in "close", we don't wait for the executor to actually shut down but it should.

      CC Andrzej Bialecki

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m