Solr
  1. Solr
  2. SOLR-1465

XPathRecordReader does a bunch of String concat using +

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Labels:
      None

      Description

      should use a StringBuilder - very inefficient to keep creating new strings that way

      1. SOLR-1465.patch
        2 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Replaced string concat with StringBuilder appends. All tests pass.

        Show
        Shalin Shekhar Mangar added a comment - Replaced string concat with StringBuilder appends. All tests pass.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 819892.

        Thanks Mark!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 819892. Thanks Mark!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development