Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14628

hl.fragsizeIsMinimum default ought to be 'true' for performance

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 8.5
    • 8.6
    • highlighter
    • None

    Description

      hl.fragsizeIsMinimum was added in 8.5 with a default setting of false – thus producing average length fragments of fragsize instead of minimum beyond fragsize. In previous releases, even though the setting didn't exist, it was in-effect true (minimum). Unfortunately, this flip was found to be a significant performance regression for highlighting lots of text (especially when using the SENTENCE break iterator), and furthermore it seems to be of relatively minor value in fragment sizing.

      I propose we flip this back to true.

      https://lists.apache.org/thread.html/r2e44d290eac9edfa61ed9eced0d9f01a7bd1cbdf910344b2aa2368b8%40%3Csolr-user.lucene.apache.org%3E

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            dsmiley David Smiley
            dsmiley David Smiley
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment