Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14596

Add equals()/hashCode() impls to SolrJ Request objects

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 8.5.2, main (9.0)
    • Fix Version/s: None
    • Component/s: SolrJ
    • Labels:
      None

      Description

      Currently, many SolrRequest classes (e.g. UpdateRequest) don't implement equals() or hashCode()

      This isn't a problem for Solr's normal operation, but it can be a barrier in unit testing SolrJ client code. equals() implementations would make it much easier to assert that client code is building the request that developers think it's building. Of course, this testing benefit would apply to Solr's own tests which use SolrJ.

      This ticket covers making sure that the more popular SolrRequest objects have equals/hashcode implementations useful for testers.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                gerlowskija Jason Gerlowski
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h