Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14568

org.apache.solr.cloud.MoveReplicaCmd#moveHdfsReplica uses hard coded timeout

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 9.0
    • None
    • SolrCloud
    • None

    Description

      org.apache.solr.cloud.MoveReplicaCmd#moveHdfsReplica gained a hardcoded timeout in SOLR-11045 but there is no clear reason discussed in that ticket and no comment in the code to indicate why it is ignoring the value of the timeout parameter already passed into that method. 

      This should be clarified in code and documented (caomanhdat?) or the timeout parameter should be supported. It sure seems like we should support the api parameter but from the pattern of commits this looks potentially intentional and has survived several revisions, so I hesitate to  just change it without input/confirmation.  If this can be clarified soon, I'll document the result it in SOLR-131699, otherwise I'll just document the state as it is, and the docs can be updated if there are changes resulting from this ticket.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              gus Gus Heck
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: