[SOLR-14467] json.facet's relatedness() should not cause server errors or nonsense results when combined with allBuckets:true

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.6, 9.0
• Component/s: Facet Module
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 08/May/20 00:36
• Updated: 15/Jul/20 15:11
• Resolved: 05/Jun/20 16:58

Description

While testing randomized permutations of json.facet params in combination with the relatedness() function it was discovered that:

• relatedness() would produce server errors in many situations when combined with allBuckets:true
• In situations where this combination of options was used an a server error did not happen, the computed values for the relatedness() function that would be put in the allBuckets bucket were meaningless

The end result of this jira was to modify relatedness() to skip computation for the allBuckets bucket

original description

While working on randomized testing for SOLR-13132 i discovered a variety of different ways that JSON Faceting's "allBuckets" option can fail when combined with the "relatedness()" function.

I haven't found a trivial way to manual reproduce this, but i have been able to trigger the failures with a trivial patch to TestCloudJSONFacetSKG which i will attach.

Based on the nature of the failures it looks like it may have something to do with multiple segments of different sizes, and or resizing the SlotAccs ?

The relatedness() function doesn't have much (any?) existing tests in place that leverage "allBuckets" so this is probably a bug that has always existed – it's possible it may be excessively cumbersome to fix and we might nee/wnat to just document that incompatibility and add some code to try and detect if the user combines these options and if so fail with a 400 error?

Issue Links

• relates to: SOLR-14514 json.facets: method:stream is incompatible with allBuckets:true
• relates to: SOLR-14520 json.facets: allBucket:true can cause server errors when combined with refine:true