[SOLR-14437] Remove/refactor "ApiSupport" interface? (for V2 API)

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 9.0
• Component/s: v2 API
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 24/Apr/20 20:15
• Updated: 27/May/20 18:05

Description

ApiSupport.java is an interface relating to the V2 API that is implemented by all request handlers, both those at a core level and others. It's essentially this: (comments removed)

public interface ApiSupport {
  Collection<Api> getApis();
  default Boolean registerV1() { return Boolean.TRUE; }
  default Boolean registerV2() { return Boolean.FALSE; }
}

Firstly, let's always assume that the handler will always be registered in V2. All implementations I've seen explicitly return true here; maybe I'm missing something though.

Secondly, getApis() seems problematic for the ability to lazily load request handlers. Can we assume, at least for core level request handlers, that there is exactly one API and where necessary rely on the "spec" JSON definition – see org.apache.solr.api.ApiBag#registerLazy ?

Issue Links

• blocks: SOLR-14394 Many request handlers should be startup=lazy