[SOLR-14425] Fix ZK sync usage to be synchronous (blocking)

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Component/s: SolrCloud
• Assignee: Unassigned
• Reporter: David Smiley
• Created: 22/Apr/20 15:01
• Updated: 20/Jul/21 03:20
• Resolved: 05/May/20 19:19

Description

As of this writing, we only use one call to ZK's "sync" method. It's related to collection aliases – I added this. I discovered I misunderstood the semantics of the API; it syncs in the background and thus returns immediately. Looking at ZK's sync CLI command and Curator both made me realize my folly. I'm considering this only a "minor" issue because I'm not sure I've seen a bug from this; or maybe I did in spooky test failures over a year ago – I'm not sure. And we don't use this pervasively (yet).

It occurred to me that if Solr embraced the Curator framework abstraction over ZooKeeper, I would not have fallen into that trap. I'll file a separate issue for that.

Issue Links

• links to: GitHub Pull Request #1446