[SOLR-14421] New examples in solr.in.cmd in Solr 8.5 don't work as provided

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 8.5, 8.5.1
• Fix Version/s: 8.6
• Assignee: Jan Høydahl
• Reporter: Colvin Cowie
• Created: 21/Apr/20 08:17
• Updated: 08/Aug/23 11:52
• Resolved: 21/Apr/20 13:12

Description

 

These SOLR_OPTS examples need to be prefixed with set and don't work when surrounded with quotes https://github.com/apache/lucene-solr/blob/master/solr/bin/solr.in.cmd#L194-L199

REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.environment=prod"

REM Specifies the path to a common library directory that will be shared across all cores.
REM Any JAR files in this directory will be added to the search path for Solr plugins.
REM If the specified path is not absolute, it will be relative to `%SOLR_HOME%`.
REM SOLR_OPTS="%SOLR_OPTS% -Dsolr.sharedLib=/path/to/lib"

Without set you will get "'SOLR_OPTS' is not recognized as an internal or external command, operable program or batch file."

After adding set, with the quotes you get "-Dsolr.environment=prod was unexpected at this time."

I'll attach a patch