[SOLR-14391] Remove getDocSet's manual doc collection logic; remove ScoreFilter

• Type: Task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 06/Apr/20 16:00
• Updated: 15/Jul/20 15:11
• Resolved: 19/Apr/20 04:09

Description

SolrIndexSearcher.getDocSet(List<Query>) calls getProcessedFilter and then basically loops over doc IDs, passing them through the filter, and passes them to the Collector. This logic is redundant with what Lucene searcher.search(query,collector) will ultimately do in BulkScorer, and so I propose we remove all that code and delegate to Lucene.

Also, the top of this method looks to see if any query implements the "ScoreFilter" marker interface (only implemented by CollapsingPostFilter) and if so delegates to getDocSetScore method instead. That method has an implementation close to what I propose getDocSet be changed to; so it can be removed along with this ScoreFilter interface searcher.search(query,collector).

Issue Links

• is a child of: SOLR-12336 Remove Filter from Solr
• is related to: SOLR-5416 CollapsingQParserPlugin breaks Tag/Exclude Faceting
• links to: GitHub Pull Request #1409