Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14391

Remove getDocSet's manual doc collection logic; remove ScoreFilter

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.6
    • Component/s: None
    • Labels:
      None

      Description

      SolrIndexSearcher.getDocSet(List<Query>) calls getProcessedFilter and then basically loops over doc IDs, passing them through the filter, and passes them to the Collector. This logic is redundant with what Lucene searcher.search(query,collector) will ultimately do in BulkScorer, and so I propose we remove all that code and delegate to Lucene.

      Also, the top of this method looks to see if any query implements the "ScoreFilter" marker interface (only implemented by CollapsingPostFilter) and if so delegates to getDocSetScore method instead. That method has an implementation close to what I propose getDocSet be changed to; so it can be removed along with this ScoreFilter interface searcher.search(query,collector).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h