Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14364

LTR SolrFeature fq improvements, like PostFilters

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.6
    • Component/s: contrib - LTR
    • Labels:
      None

      Description

      While working on another issue, I came upon LTR's SolrFeature class which calls SolrIndexSearcher.getProcessedFilter – a rather low-level method that that nobody should call directly if they can help it.  Furthermore, the way SolrFeature was processing the filter queries didn't support PostFilters, which would have been silently ignored (ouch!).  After looking around this SolrFeature class I found multiple things to improve to reduce complexity, perhaps performance in some cases, and IMO improve readability.  In my PR it has about 80 fewer lines of code now.  Additionally I found it useful to add a new utility method combineQueryAndFilter that is useful in quite a few places across Solr (and my PR does so).

      I have some complaints with other things I see but want to stop here, with my primary objective of reducing a needless caller on getProcessedFilter.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3.5h
                  3.5h