[SOLR-14351] Harden MDCLoggingContext.clear depth tracking

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 20/Mar/20 04:49
• Updated: 15/Jul/20 15:10
• Resolved: 04/Apr/20 02:23

Description

MDCLoggingContext tracks recursive calls and only clears when the recursion level is back down to 0.  If a caller forgets to register and ends up calling clear any ways, then this can mess things up.  Additionally I found at least one place this is occurring, which led me to investigate this matter.

Issue Links

• fixes: SOLR-7699 Clean up too verbose code in SOLR-7590.
• links to: GitHub Pull Request #1368
• links to: GitHub Pull Request #1498