Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14342

CoreSorter is partially broken, thus core loading order is sub-optimal

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.6
    • Component/s: SolrCloud
    • Labels:

      Description

      In SOLR-7280, it Solr was supposedly improved to load cores in a more optimal order in SolrCloud, considering the state of collections across the cluster.  The CoreContainer uses CoreSorter for this.  Unfortunately, CoreSorter's attempts to gather statistics early on in CoreSorter.init() operate on an empty list and do nothing (i.e. dead code). The root cause is that getCloudDescriptors() works by looking at cc.getCores however at this stage there are no cores ! (We haven't sorted them so they certainly haven't been loaded yet.   I have a fix.

      This might be classified as a bug fix but the core load order is more about optimization, so a fix to a wrong/incomplete optimization isn't really a bug from a user's point of view.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 50m
                  1h 50m