Solr
  1. Solr
  2. SOLR-1433

files included in release that shouldn't be

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      some files are making it into the release artifacts that shouldn't be ... need to take care of this in the build file prior to releasing 1.4. details to follow in comments.

      1. SOLR-1433-4-5.patch
        1 kB
        Shalin Shekhar Mangar
      2. SOLR-1433-3.patch
        0.6 kB
        Shalin Shekhar Mangar
      3. SOLR-1433-1-2.patch
        2 kB
        Shalin Shekhar Mangar
      4. SOLR-1433-1.patch
        1 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hoss Man created issue -
          Hide
          Hoss Man added a comment -

          These nots are all as of r815491, looking at the contents of apache-solr-1.4-dev.tgz...

          1) These just shouldn't be in the release at all..

          ./contrib/clustering/build
          ./contrib/extraction/build

          2) These are jar files containing src and javadocs ... but we already include the src and java directly. I suspect these are built for maven, but they either need to be excluded from the zip/tgz package files, or we need to exclude the raw files from the package files (and update our READMEs)

          ./dist/apache-solr-cell-docs-1.4-dev.jar
          ./dist/apache-solr-cell-src-1.4-dev.jar
          ./dist/apache-solr-clustering-docs-1.4-dev.jar
          ./dist/apache-solr-clustering-src-1.4-dev.jar
          ./dist/apache-solr-core-docs-1.4-dev.jar
          ./dist/apache-solr-core-src-1.4-dev.jar
          ./dist/apache-solr-dataimporthandler-docs-1.4-dev.jar
          ./dist/apache-solr-dataimporthandler-extras-src-1.4-dev.jar
          ./dist/apache-solr-dataimporthandler-src-1.4-dev.jar
          ./dist/apache-solr-solrj-docs-1.4-dev.jar
          ./dist/apache-solr-solrj-src-1.4-dev.jar

          3) This seems odd, shouldn't this jar be in the ./dist directory? ...

          ./contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4-dev.jar

          4) These are duplicated in ./dist/solr-cell-lib/ ...

          ./contrib/extraction/lib/asm-3.1.jar
          ./contrib/extraction/lib/bcmail-jdk14-136.jar
          ./contrib/extraction/lib/bcprov-jdk14-136.jar
          ./contrib/extraction/lib/commons-codec-1.3.jar
          ./contrib/extraction/lib/commons-compress-1.0.jar
          ./contrib/extraction/lib/commons-io-1.4.jar
          ./contrib/extraction/lib/commons-lang-2.1.jar
          ./contrib/extraction/lib/commons-logging-1.1.1.jar
          ./contrib/extraction/lib/dom4j-1.6.1.jar
          ./contrib/extraction/lib/fontbox-0.1.0.jar
          ./contrib/extraction/lib/geronimo-stax-api_1.0_spec-1.0.jar
          ./contrib/extraction/lib/icu4j-3.8.jar
          ./contrib/extraction/lib/jempbox-0.2.0.jar
          ./contrib/extraction/lib/log4j-1.2.14.jar
          ./contrib/extraction/lib/nekohtml-1.9.9.jar
          ./contrib/extraction/lib/ooxml-schemas-1.0.jar
          ./contrib/extraction/lib/pdfbox-0.7.3.jar
          ./contrib/extraction/lib/poi-3.5-beta6.jar
          ./contrib/extraction/lib/poi-ooxml-3.5-beta5.jar
          ./contrib/extraction/lib/poi-ooxml-3.5-beta6.jar
          ./contrib/extraction/lib/poi-scratchpad-3.5-beta6.jar
          ./contrib/extraction/lib/tika-core-0.4.jar
          ./contrib/extraction/lib/tika-parsers-0.4.jar
          ./contrib/extraction/lib/xercesImpl-2.8.1.jar
          ./contrib/extraction/lib/xml-apis-1.0.b2.jar
          ./contrib/extraction/lib/xmlbeans-2.3.0.jar

          5) These are duplicated in ./dist/solr-clustering-lib/ ...

          ./contrib/clustering/lib/carrot2-mini-3.0.1.jar
          ./contrib/clustering/lib/commons-lang-2.4.jar
          ./contrib/clustering/lib/ehcache-1.6.0-beta3.jar
          ./contrib/clustering/lib/google-collections.jar
          ./contrib/clustering/lib/jackson-0.9.2-patched.jar
          ./contrib/clustering/lib/log4j-1.2.14.jar

          6) these are duplicated in ./dist/solrj-lib/ ...

          ./lib/commons-codec-1.3.jar
          ./lib/commons-httpclient-3.1.jar
          ./lib/commons-io-1.4.jar
          ./lib/geronimo-stax-api_1.0_spec-1.0.1.jar
          ./lib/jcl-over-slf4j-1.5.5.jar
          ./lib/wstx-asl-3.2.7.jar

          Show
          Hoss Man added a comment - These nots are all as of r815491, looking at the contents of apache-solr-1.4-dev.tgz... 1) These just shouldn't be in the release at all.. ./contrib/clustering/build ./contrib/extraction/build 2) These are jar files containing src and javadocs ... but we already include the src and java directly. I suspect these are built for maven, but they either need to be excluded from the zip/tgz package files, or we need to exclude the raw files from the package files (and update our READMEs) ./dist/apache-solr-cell-docs-1.4-dev.jar ./dist/apache-solr-cell-src-1.4-dev.jar ./dist/apache-solr-clustering-docs-1.4-dev.jar ./dist/apache-solr-clustering-src-1.4-dev.jar ./dist/apache-solr-core-docs-1.4-dev.jar ./dist/apache-solr-core-src-1.4-dev.jar ./dist/apache-solr-dataimporthandler-docs-1.4-dev.jar ./dist/apache-solr-dataimporthandler-extras-src-1.4-dev.jar ./dist/apache-solr-dataimporthandler-src-1.4-dev.jar ./dist/apache-solr-solrj-docs-1.4-dev.jar ./dist/apache-solr-solrj-src-1.4-dev.jar 3) This seems odd, shouldn't this jar be in the ./dist directory? ... ./contrib/velocity/src/main/solr/lib/apache-solr-velocity-1.4-dev.jar 4) These are duplicated in ./dist/solr-cell-lib/ ... ./contrib/extraction/lib/asm-3.1.jar ./contrib/extraction/lib/bcmail-jdk14-136.jar ./contrib/extraction/lib/bcprov-jdk14-136.jar ./contrib/extraction/lib/commons-codec-1.3.jar ./contrib/extraction/lib/commons-compress-1.0.jar ./contrib/extraction/lib/commons-io-1.4.jar ./contrib/extraction/lib/commons-lang-2.1.jar ./contrib/extraction/lib/commons-logging-1.1.1.jar ./contrib/extraction/lib/dom4j-1.6.1.jar ./contrib/extraction/lib/fontbox-0.1.0.jar ./contrib/extraction/lib/geronimo-stax-api_1.0_spec-1.0.jar ./contrib/extraction/lib/icu4j-3.8.jar ./contrib/extraction/lib/jempbox-0.2.0.jar ./contrib/extraction/lib/log4j-1.2.14.jar ./contrib/extraction/lib/nekohtml-1.9.9.jar ./contrib/extraction/lib/ooxml-schemas-1.0.jar ./contrib/extraction/lib/pdfbox-0.7.3.jar ./contrib/extraction/lib/poi-3.5-beta6.jar ./contrib/extraction/lib/poi-ooxml-3.5-beta5.jar ./contrib/extraction/lib/poi-ooxml-3.5-beta6.jar ./contrib/extraction/lib/poi-scratchpad-3.5-beta6.jar ./contrib/extraction/lib/tika-core-0.4.jar ./contrib/extraction/lib/tika-parsers-0.4.jar ./contrib/extraction/lib/xercesImpl-2.8.1.jar ./contrib/extraction/lib/xml-apis-1.0.b2.jar ./contrib/extraction/lib/xmlbeans-2.3.0.jar 5) These are duplicated in ./dist/solr-clustering-lib/ ... ./contrib/clustering/lib/carrot2-mini-3.0.1.jar ./contrib/clustering/lib/commons-lang-2.4.jar ./contrib/clustering/lib/ehcache-1.6.0-beta3.jar ./contrib/clustering/lib/google-collections.jar ./contrib/clustering/lib/jackson-0.9.2-patched.jar ./contrib/clustering/lib/log4j-1.2.14.jar 6) these are duplicated in ./dist/solrj-lib/ ... ./lib/commons-codec-1.3.jar ./lib/commons-httpclient-3.1.jar ./lib/commons-io-1.4.jar ./lib/geronimo-stax-api_1.0_spec-1.0.1.jar ./lib/jcl-over-slf4j-1.5.5.jar ./lib/wstx-asl-3.2.7.jar
          Grant Ingersoll made changes -
          Field Original Value New Value
          Link This issue incorporates SOLR-1300 [ SOLR-1300 ]
          Grant Ingersoll made changes -
          Assignee Grant Ingersoll [ gsingers ]
          Hide
          Shalin Shekhar Mangar added a comment -

          Fixes #1 by changing the excludes attribute from

          contrib/**/build/*

          to

          contrib/**/build
          Show
          Shalin Shekhar Mangar added a comment - Fixes #1 by changing the excludes attribute from contrib/**/build/* to contrib/**/build
          Shalin Shekhar Mangar made changes -
          Attachment SOLR-1433-1.patch [ 12420686 ]
          Hide
          Shalin Shekhar Mangar added a comment -

          Fixes 1 and 2.

          Show
          Shalin Shekhar Mangar added a comment - Fixes 1 and 2.
          Shalin Shekhar Mangar made changes -
          Attachment SOLR-1433-1-2.patch [ 12420688 ]
          shalin committed 819478 (1 file)
          Reviews: none

          SOLR-1433 -- Remove clustering/build, extraction/build, src and javadoc jars from release

          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 819478.

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 819478.
          Hide
          Shalin Shekhar Mangar added a comment -

          Fix for 3. I'll commit this shortly.

          Show
          Shalin Shekhar Mangar added a comment - Fix for 3. I'll commit this shortly.
          Shalin Shekhar Mangar made changes -
          Attachment SOLR-1433-3.patch [ 12420699 ]
          shalin committed 819538 (1 file)
          Reviews: none

          SOLR-1433 followup -- Moving apache-solr-velocity-1.4-dev.jar to dist directory

          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 819538.

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 819538.
          Hide
          Shalin Shekhar Mangar added a comment -

          Regarding 4, 5 and 6, I believe those copies are done so that users know where to find all the dependencies for the given component. This is actually very helpful for people who use Solrj with ant since its dependencies are mixed with core dependencies in the lib directory.

          However for something like clustering it does not make much sense because ./dist/solr-clustering-lib/ does not contain all the jars (there are other jars which we cannot distribute). Velocity contrib and DIH extras do not make such copies.

          We could do one the following:

          1. Remove dist/solr-cell-lib, dist/solr-clustering-lib and let users copy dependencies from the respective contrib's lib directory. Keep dist/solrj-lib around though.
          2. Move these jars from respective contrib/lib and keep them in lib/<contrib-name>. Modify build classpaths in contrib builds to point to these new directories.
          Show
          Shalin Shekhar Mangar added a comment - Regarding 4, 5 and 6, I believe those copies are done so that users know where to find all the dependencies for the given component. This is actually very helpful for people who use Solrj with ant since its dependencies are mixed with core dependencies in the lib directory. However for something like clustering it does not make much sense because ./dist/solr-clustering-lib/ does not contain all the jars (there are other jars which we cannot distribute). Velocity contrib and DIH extras do not make such copies. We could do one the following: Remove dist/solr-cell-lib, dist/solr-clustering-lib and let users copy dependencies from the respective contrib's lib directory. Keep dist/solrj-lib around though. Move these jars from respective contrib/lib and keep them in lib/<contrib-name>. Modify build classpaths in contrib builds to point to these new directories.
          Hide
          Grant Ingersoll added a comment -

          I think the libs were done this way just as a mimic of what SolrJ does.

          Show
          Grant Ingersoll added a comment - I think the libs were done this way just as a mimic of what SolrJ does.
          Grant Ingersoll made changes -
          Link This issue is related to SOLR-1449 [ SOLR-1449 ]
          Hide
          Shalin Shekhar Mangar added a comment -

          I think the libs were done this way just as a mimic of what SolrJ does.

          Hmm, so should I go ahead with option 1?

          Show
          Shalin Shekhar Mangar added a comment - I think the libs were done this way just as a mimic of what SolrJ does. Hmm, so should I go ahead with option 1?
          Hide
          Grant Ingersoll added a comment -

          Seems fine by me as long as it doesn't break anything.

          Show
          Grant Ingersoll added a comment - Seems fine by me as long as it doesn't break anything.
          Hide
          Shalin Shekhar Mangar added a comment -

          Prevents extraction/lib and clustering/lib from being copied into the lib directory. I'll commit this shortly.

          Show
          Shalin Shekhar Mangar added a comment - Prevents extraction/lib and clustering/lib from being copied into the lib directory. I'll commit this shortly.
          Shalin Shekhar Mangar made changes -
          Attachment SOLR-1433-4-5.patch [ 12420725 ]
          shalin committed 819714 (2 files)
          Reviews: none

          SOLR-1433 followup -- Prevent extraction/lib and clustering/lib from being copied into the lib directory

          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 819714.

          SOLR-1300 will be dealt with separately.

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 819714. SOLR-1300 will be dealt with separately.
          Shalin Shekhar Mangar made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Assignee Grant Ingersoll [ gsingers ] Shalin Shekhar Mangar [ shalinmangar ]
          Resolution Fixed [ 1 ]
          Hide
          Grant Ingersoll added a comment -

          Bulk close for Solr 1.4

          Show
          Grant Ingersoll added a comment - Bulk close for Solr 1.4
          Grant Ingersoll made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development