[SOLR-14260] Make SchemaRegistryProvider pluggable in HttpClientUtil

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Component/s: SolrJ
• Assignee: David Smiley
• Reporter: Andy Throgmorton
• Created: 12/Feb/20 23:44
• Updated: 15/Jul/20 15:09
• Resolved: 27/Mar/20 03:24

Description

HttpClientUtil.java defines and uses an abstract SchemaRegistryProvider for mapping a protocol to an Apache ConnectionSocketFactory. There is only one implementation of this abstract class (outside of test cases). Currently, it is not override-able at runtime.

This PR adds the ability to override the registry provider at runtime, using the class name value provided by "solr.httpclient.socketFactory.registry.provider", similar to how this class allows for choosing the HttpClientBuilderFactory at runtime.  And SchemaRegistryProvider is renamed to SocketFactoryRegistryProvider.

We've implemented a custom mTLS solution in Solr (which uses a custom SSL context). This change helps us more easily configure Solr in a modular way, since we've implemented a custom SocketFactoryRegistryProvider that configures Apache clients to use our SSL context.

Issue Links

• links to: GitHub Pull Request #1261