[SOLR-14204] Rethink PKIs hueristic for dealing with 'isSolrThread()'

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Chris M. Hostetter
• Created: 22/Jan/20 17:58
• Updated: 27/May/20 18:05

Description

See SOLR-12859 for a lengthy discussion of some of the problems that currently exist with the way PKIAuthenticationPlugin's isSolrThread() currently works, and some discussions around how to possibly fix it.

Notably:

• anything request that comes from a Threadpool is considered isSolrThread()
  • which means every frequest from ConcurrentUpdateSolrClient is considered isSolrThread()
• but isSolrThread() is ignored if there is a SolrRequestInfo
  • but many code paths (like DocExpirationUpdateProcessorFactory -> UpdateProcessorChain) require that a SolrRequestInfo be set in order to function properly

In general, there's also a lot of questions/confusions about why isSolrThread() exists at all

Issue Links

• is related to: SOLR-12859 DocExpirationUpdateProcessorFactory does not work with BasicAuth (and other auth plugins that use PKI)