[SOLR-14197] Reduce API of SolrResourceLoader

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.6
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 21/Jan/20 13:51
• Updated: 01/Dec/20 20:42
• Resolved: 12/Mar/20 04:08

Description

SolrResourceLoader must exist as an implementation of Lucene ResourceLoader. Over time it has grown a lot more methods that are beyond the scope of doing just that. I think SRL should be simplified to get back to its core necessity, which hopefully allows us to make other changes (either in SRL or nearby) with less entanglement. Some API creep:

• listConfigDir (not used)
• newAdminHandlerInstance (not used)
• getDataDir
• getCoreName (only used for logging)
• getCoreProperties
• openSchema and configSchema (not needed; barely used)

EDIT: The following to be done in a follow-up issue:
Some methods ought to go to a new subclass of SolrResourceLoader that is specifically for a standalone-mode core:

• resourceLocation
• getConfigDir
• getInstancePath
• persistConfLocally

Issue Links

• relates to: SOLR-15017 The core's lib/ folder content is not loaded in the classloader anymore when the core's configuration does not define any <lib> element
• links to: GitHub Pull Request #1191