Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14197

Reduce API of SolrResourceLoader

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.6
    • Component/s: None
    • Labels:
      None

      Description

      SolrResourceLoader must exist as an implementation of Lucene ResourceLoader. Over time it has grown a lot more methods that are beyond the scope of doing just that. I think SRL should be simplified to get back to its core necessity, which hopefully allows us to make other changes (either in SRL or nearby) with less entanglement. Some API creep:

      • listConfigDir (not used)
      • newAdminHandlerInstance (not used)
      • getDataDir
      • getCoreName (only used for logging)
      • getCoreProperties
      • openSchema and configSchema (not needed; barely used)

      EDIT: The following to be done in a follow-up issue:
      Some methods ought to go to a new subclass of SolrResourceLoader that is specifically for a standalone-mode core:

      • resourceLocation
      • getConfigDir
      • getInstancePath
      • persistConfLocally

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dsmiley David Smiley
                Reporter:
                dsmiley David Smiley
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3h 50m
                  3h 50m