[SOLR-14186] Ensure Windows files retain CRLF endings

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.4, 9.0
• Fix Version/s: 8.4.2, 8.5, 9.0
• Component/s: scripts and tools
• Assignee: Jason Gerlowski
• Reporter: Jason Gerlowski
• Created: 13/Jan/20 15:06
• Updated: 24/Mar/20 12:46
• Resolved: 16/Jan/20 17:20

Description

We've had several recent instances where our Windows files (solr.cmd, solr.in.cmd) end up getting their Windows-specific line-endings stripped out. This causes chunks of those scripts to fail when run on Windows.

e.g. SOLR-13977 fixed an issue where bin\solr.cmd create -c failed, and the problem was fixed and recurred again within a week.

Generally, contributors/committers can prevent this by setting their core.autocrlf git setting to input. But we should also put repository-wide settings in place exempting certain files from line-ending conversion entirely.

This issue proposes adding a .gitattributes setting to special-case OS-specific files (bash scripts, Windows batch files, etc.) This will prevent solr.cmd's line endings from being changed by committers who forget to configure the setting on a new machine, etc.

Issue Links

• links to: GitHub Pull Request #1162
• links to: GitHub Pull Request #1163