[SOLR-14184] replace DirectUpdateHandler2.commitOnClose with (negated) TestInjection.skipIndexWriterCommitOnClose

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.5, 9.0
• Assignee: Chris M. Hostetter
• Reporter: Chris M. Hostetter
• Created: 11/Jan/20 23:27
• Updated: 24/Mar/20 12:45
• Resolved: 16/Jan/20 21:53

Description

public static volatile boolean commitOnClose = true;  // TODO: make this a real config option or move it to TestInjection

Lots of tests muck with this (to simulate unclean shutdown and force tlog replay on restart) but there's no garuntee that it is reset properly.

It should be replaced by logic in TestInjection that is correctly cleaned up by TestInjection.reset()

---

It's been replaced with the (negated) option TestInjection.skipIndexWriterCommitOnClose which is automatically reset to it's default value of false by TestInjection.reset()

Issue Links

• is related to: SOLR-13486 race condition between leader's "replay on startup" and non-leader's "recover from leader" can leave replicas out of sync (TestTlogReplayVsRecovery)