Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-14184

replace DirectUpdateHandler2.commitOnClose with (negated) TestInjection.skipIndexWriterCommitOnClose

    XMLWordPrintableJSON

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: master (9.0), 8.5
    • Component/s: None
    • Labels:
      None

      Description

      public static volatile boolean commitOnClose = true;  // TODO: make this a real config option or move it to TestInjection
      

      Lots of tests muck with this (to simulate unclean shutdown and force tlog replay on restart) but there's no garuntee that it is reset properly.

      It should be replaced by logic in TestInjection that is correctly cleaned up by TestInjection.reset()


      It's been replaced with the (negated) option TestInjection.skipIndexWriterCommitOnClose which is automatically reset to it's default value of false by TestInjection.reset()

        Attachments

        1. SOLR-14184.patch
          6 kB
          Chris M. Hostetter
        2. SOLR-14184.patch
          38 kB
          Chris M. Hostetter

          Issue Links

            Activity

              People

              • Assignee:
                hossman Chris M. Hostetter
                Reporter:
                hossman Chris M. Hostetter
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: