[SOLR-1417] solrj DocumentObjectBinder prints to stdout rather than using slf4j

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4
• Component/s: clients - java
• Assignee: Unassigned
• Reporter: Ilan Rabinovitch
• Created: 09/Sep/09 02:40
• Updated: 09/Sep/09 03:50
• Resolved: 09/Sep/09 03:50

Description

We have nnoticed that in trunk the inject method of DocumentObjectBinder [1] for solrj logs to standard out using System.out.println if any variables in the returned result have a null value. Since system.out is not configurable this can get quite spammy on the console.

Should this be logging at the INFO/DEBUG level using slf4j instead?

The system.out.println statement was added on 2009-07-14 as part of SOLR-1129 (r794144).

—

[1] src/solrj/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java:316 (r794144)

<T> void inject(T obj, SolrDocument sdoc) {
Object val = getFieldValue(sdoc);
if(val == null)

{ System.out.println("val null for "+ name); return; }

Issue Links

• is related to: SOLR-1129 SolrJ cannot bind dynamic fields to beans