Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-1417

solrj DocumentObjectBinder prints to stdout rather than using slf4j

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: None
    • Component/s: clients - java
    • Labels:
      None

      Description

      We have nnoticed that in trunk the inject method of DocumentObjectBinder [1] for solrj logs to standard out using System.out.println if any variables in the returned result have a null value. Since system.out is not configurable this can get quite spammy on the console.

      Should this be logging at the INFO/DEBUG level using slf4j instead?

      The system.out.println statement was added on 2009-07-14 as part of SOLR-1129 (r794144).

      [1] src/solrj/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java:316 (r794144)

      <T> void inject(T obj, SolrDocument sdoc) {
      Object val = getFieldValue(sdoc);
      if(val == null)

      { System.out.println("val null for "+ name); return; }

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                irabinovitch Ilan Rabinovitch
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: